[wp-trac] [WordPress Trac] #44197: ZIP file containing a user’s personal data has user’s personal data in filename

[WordPress Trac]

#44197: ZIP file containing a user’s personal data has user’s personal data in
filename
-------------------------------------+---------------------
 Reporter:  Ov3rfly                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.4
Component:  Privacy                  |     Version:  4.9.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+---------------------
Changes (by xkon):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 Hey @donmhico, thanks for the patch!

 Since the `$stripped_email` is completely removed on your patch and not
 even used for an extra hash then I think that its assignment references
 that are on the same block can also be removed.

 {{{
 $stripped_email       = str_replace( '@', '-at-', $email_address );
 $stripped_email       = sanitize_title( $stripped_email ); // slugify the
 email address
 }}}

 As side notes, most likely phpunit tests will also need updating due to
 this name change and even though the exporter will first check out if a
 zip exists attached to the existing request and re-use that name it would
 be good to cross-test that to avoid breaking any existing sent e-mails :).

 Would you like to update the patch and take a look at unit tests as well?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44197#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform