[wp-trac] [WordPress Trac] #48772: Missing post ID as parameter for get_comments_number_text()

WordPress Trac noreply at wordpress.org
Mon Jan 27 10:08:06 UTC 2020


#48772: Missing post ID as parameter for get_comments_number_text()
------------------------------+-----------------------
 Reporter:  Hinjiriyo         |       Owner:  donmhico
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  5.4
Component:  Comments          |     Version:  4.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by donmhico):

 Thanks @imath and thank you @garrett-eclipse for your explanation.
 @Hinjiriyo we can't just change function parameters, especially to
 publicly exposed functions, in WP. I decided to follow [34118] because I
 believe there's a "good" reason why it was done like that and like
 @garrett-eclipse explained, it's most probably for backward-compat and to
 make sure that this change won't break anything.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48772#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list