[wp-trac] [WordPress Trac] #44266: Add per-request-row delete row action for privacy actions
WordPress Trac
noreply at wordpress.org
Mon Jan 27 07:52:00 UTC 2020
#44266: Add per-request-row delete row action for privacy actions
-------------------------------------------------+-------------------------
Reporter: allendav | Owner: xkon
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.4
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch needs-testing has- | Focuses:
screenshots |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: has-patch needs-testing 2nd-opinion has-screenshots => has-
patch needs-testing has-screenshots
Comment:
Thanks @xkon I appreciate the initial patch here, it worked very nicely.
I've refreshed in
[https://core.trac.wordpress.org/attachment/ticket/44266/44266.2.diff
44266.2.diff] to update the following;
1. Updated the verbiage and classes to match #44674.
2. Updated the translator comments to match the placeholder.
3. Fixed some formatting for CS.
4. Updated the delete action for the single request to match the resend by
providing the email in the notice.
5. Updated the resend multiple to keep it's plural form to support
russian/arabic and other languages with multiple plural forms.
Uploaded screens to show the actions in action on both request tables.
If you can retest I think this can move forward. I was initially hesitant
to use the bulk action here but it works nicely and when the list tables
are updated in #47488 we can revisit how the row actions are handled.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44266#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list