[wp-trac] [WordPress Trac] #49291: Code issues with set_time_limit

[WordPress Trac]

#49291: Code issues with set_time_limit
-------------------------------+------------------------------------------
 Reporter:  madpeter           |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Revisions          |     Version:  5.3.2
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:  administration, performance
-------------------------------+------------------------------------------
Changes (by madpeter):

 * keywords:   => reporter-feedback


Comment:

 The set_time_limit( 0 ) instance in wp_ajax_get_revision_diffs() was
 introduced in [24707] / #24757. Could you clarify why the value should be
 changed to 120?

 if a badly coded plugin calls wp_ajax_get_revision_diffs but does not call
 set_time_limit itself and then it hangs due to a bug it can hold php
 active and not free up memory or worse use a while loop to hog cpu time.

 but having a known limit for all set_time_limit calls it can help
 highlight issues with poorly coded plugins as it will create php time out
 warnings.



 class-pop3.php
 I will need to open a new ticket as wordpresses copy of phpmailer to far
 out of date.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49291#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform