[wp-trac] [WordPress Trac] #44674: Privacy Bulk Action 'Remove' should be 'Delete' or 'Move to Trash' to follow convention

WordPress Trac noreply at wordpress.org
Sun Jan 26 22:29:18 UTC 2020


#44674: Privacy Bulk Action 'Remove' should be 'Delete' or 'Move to Trash' to
follow convention
---------------------------------------+-----------------------------
 Reporter:  garrett-eclipse            |       Owner:  xkon
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.4
Component:  Privacy                    |     Version:  4.9.6
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  administration
---------------------------------------+-----------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch has-screenshots 2nd-opinion => has-patch has-
     screenshots


Comment:

 Thanks for the patch @xkon I've made a minor refresh in
 [https://core.trac.wordpress.org/attachment/ticket/44674/44674.4.diff
 44674.4.diff] which changed `Re-send Confirmation Emails` to `Resend
 Confirmation Requests`.
 *English is weird... you use a dash when if an email was `re-sent` but
 don't use it when you `resend` an email. This is because `re-send` isn't a
 word. And it's `re-sent` to avoid confusion with `resent` which is when
 you dislike/hate something.
 **I went with Confirmation Requests instead of Confirmation Emails as
 there's the possibility of SMS delivery (some plugins replace email sends
 with SMS) and it matches the other messages such as the success on this
 action which states 'Re-sent %n request(s)'.

 Take a look and if you're happy with that let's mark for commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44674#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list