[wp-trac] [WordPress Trac] #46894: Personal Data Export Report: Table of contents for easier navigation

[WordPress Trac]

#46894: Personal Data Export Report: Table of contents for easier navigation
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui
  testing dev-feedback                           |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch
     needs-testing dev-feedback


Comment:

 Thanks @xkon for starting this. I've refreshed you patch in
 [https://core.trac.wordpress.org/attachment/ticket/46894/46894.4.diff
 46894.4.diff] to address the following;
 1. Make 'Table of Contents' translatable.
 2. Use Escape functions on the output and sanitize_title_width_dashes to
 lowercase and replace spaces with '-'.
 https://developer.wordpress.org/themes/theme-security/data-sanitization-
 escaping/
 3. Fixed the Unit Tests to introduce the id attr we added on sections.
 *These tests are what drove me to switch to esc_attr( sanitize_title() )
 for lowercase and dashes

 I also uploaded an experiment in
 [https://core.trac.wordpress.org/attachment/ticket/46894/46894.4.alt.diff
 46894.4.alt.diff] as there's potential that two plugins could use the same
 Group Label, say two gallery plugins with 'Images' groups. @xkon what are
 your thoughts? it passes the group_id along as it's more likely to be
 unique and appends it to the group label. We could just use the group_id,
 but if no slug is provided when registering the data it'll us a numeric so
 I didn't want to leave html ids with just numbers. I'm on the fence of
 this so uploaded as an alt for feedback.
 *Mainly on the fence as it ends up with id's like `about-about` and `test-
 group-data-test-group-data`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46894#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform