[wp-trac] [WordPress Trac] #48772: Missing post ID as parameter for get_comments_number_text()

[WordPress Trac]

#48772: Missing post ID as parameter for get_comments_number_text()
-------------------------------------+-----------------------
 Reporter:  Hinjiriyo                |       Owner:  donmhico
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.4
Component:  Comments                 |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------
Changes (by garrett-eclipse):

 * keywords:  dev-feedback has-patch needs-testing => has-patch needs-
               testing


Comment:

 Thanks @Hinjiriyo
 I assume @donmhico preserved the deprecated parameter as it appears that
 is the standard convention for this type of thing. For instance wp_install
 has a 5th param that's deprecated but also then has a 6th and 7th. By not
 removing the deprecated param we preserve the call to
 `_deprecated_argument` which flags to users they're misusing the function.
 Adding an addition instead of replacing in this case is primarily for
 back-compat reason.
 * @donmhico correct me if I'm wrong

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48772#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform