[wp-trac] [WordPress Trac] #48772: Missing post ID as parameter for get_comments_number_text()

WordPress Trac noreply at wordpress.org
Fri Jan 24 20:13:25 UTC 2020


#48772: Missing post ID as parameter for get_comments_number_text()
--------------------------------------------------+-----------------------
 Reporter:  Hinjiriyo                             |       Owner:  donmhico
     Type:  enhancement                           |      Status:  assigned
 Priority:  normal                                |   Milestone:  5.4
Component:  Comments                              |     Version:  4.0
 Severity:  normal                                |  Resolution:
 Keywords:  dev-feedback has-patch needs-testing  |     Focuses:
--------------------------------------------------+-----------------------
Changes (by garrett-eclipse):

 * keywords:  dev-feedback has-patch => dev-feedback has-patch needs-testing


Comment:

 Hi @donmhico thanks for the updated patch.

 Testing on trunk I wasn't able to apply it so made a refresh in
 [https://core.trac.wordpress.org/attachment/ticket/48772/48772.4.diff
 48772.4.diff]. Also in this I've made two minor tweaks;
 1. Updated @since 5.4 to use proper semver 5.4.0
 2. Updated docblock for `get_comments_number_text` to have similar
 indentation as `comments_number` for CS.

 With my refresh tests are still passing here but will leave for a Comments
 maintainer to sign off.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48772#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list