[wp-trac] [WordPress Trac] #43358: The theme/plugin editor sandbox does not play well with PHP sessions

[WordPress Trac]

#43358: The theme/plugin editor sandbox does not play well with PHP sessions
----------------------------+-----------------------------
 Reporter:  bruandet        |       Owner:  SergeyBiryukov
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  5.4
Component:  Administration  |     Version:  4.9.4
 Severity:  normal          |  Resolution:
 Keywords:  dev-feedback    |     Focuses:
----------------------------+-----------------------------
Changes (by donmhico):

 * keywords:   => dev-feedback


Comment:

 +1 to @bruandet. Adding `session_write_close()` before the first
 `wp_remote_get()` specifically here -
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/file.php#L554 - fixes the issue for the Plugin and Theme
 editor. However it does not fix the issue found in Site Health checks.

 Do you guys think that closing the session during the Site Health checks
 is the proper solution? It feels kinda hacky if you ask me. Any other
 ideas / approach?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43358#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform