[wp-trac] [WordPress Trac] #39074: No method to move meta boxes using keyboard

[WordPress Trac]

#39074: No method to move meta boxes using keyboard
-------------------------------------+-------------------------------------
 Reporter:  joedolson                |       Owner:  xkon
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.4
Component:  Editor                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  wpcampus-report has-     |     Focuses:  ui, accessibility,
  patch needs-design-feedback has-   |  administration
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by xkon):

 [attachment:"39074.4.diff"] is a "restart" following the feedback from
 comment [comment:31].

 - CSS classes for buttons are now `handle-order-higher`, `handle-order-
 lower` and their indicators as `order-higher-indicator` and `order-lower-
 indicator` to avoid the usage of `Toggle`.

 - The screen reader texts have been adjusted to `'Order %s panel lower'`
 and `'Order %s panel higher'`.

 - The buttons now have an `aria-disabled` attribute with a true/false
 value depending on their position on page load which is being updated on
 click depending on the case if ordering higher/lower is possible.

 - Regarding the JS a `handle_order` has been created to avoid using the
 existing `handle_click` and split up these actions on their own.

 - Further adjustments have been made to CSS & `template.php` to group the
 3 handles into a div to match the DOM with the visual order.

 ---

 @afercia if we go towards the way of allowing postboxes to move between
 groups as well, there's no need for a disabled move higher/lower button as
 essentially like you said it will be in a loop. I do think though that for
 now we should keep the boxes in the same groups and see a full cycle maybe
 after 5.4 (?).

 Regarding the advanced group, I think we should make it to 36px by default
 (that's the height of a postbox heading) and add a visual border similar
 to what an empty group has on Dashboard. Since there's no border at all
 even if we adjust the height there will still be no visual indication that
 an extra group exists. Would that be ok?

 ---

 Remaining suggestions for next patch:
 - Adjust the aria-disabled of all postboxes in the same Sortables region
 as at the moment in some cases they might remain disabled.
 - Use a speak() message when the order is saved successfully via Ajax.
 - Advanced group (if not decided to be split on a different ticket).
 - Any other fixes from further comments :-).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39074#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform