[wp-trac] [WordPress Trac] #49282: Cleanup Privacy .wp-policy-help CSS remnants (Broken back-compat)

[WordPress Trac]

#49282: Cleanup Privacy .wp-policy-help CSS remnants (Broken back-compat)
------------------------------------------------+---------------------
 Reporter:  garrett-eclipse                     |       Owner:  (none)
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  5.4
Component:  Privacy                             |     Version:  5.1
 Severity:  normal                              |  Resolution:
 Keywords:  needs-docs has-patch needs-testing  |     Focuses:  css
------------------------------------------------+---------------------
Changes (by garrett-eclipse):

 * keywords:  needs-docs needs-patch => needs-docs has-patch needs-testing
 * version:   => 5.1


Comment:

 Thanks @azaozz I've uploaded [] to account for these items;
 1. Deprecate .wp-policy-help from the tinymce css.
 2. Add back-compat CSS to hide .wp-policy-help from the copy command, and
 remove italic font so it displays and functions the same as `.privacy-
 policy-tutorial`
 3. I've added the following to the docblock for
 `wp_add_privacy_policy_content` in order to introduce this to the Function
 Reference. It's a little verbose so if there's any feedback on making it
 more concise I'm open to that.

 > The HTML contents of the `$policy_text` supports use of a specialized
 `privacy-policy-tutorial` css class which can be used to provide
 supplemental information. Any content contained within html elements that
 have the `privacy-policy-tutorial` css class applied will be omitted from
 the clipboard when the section content is copied.

 4. [NEW] While testing I found the tutorial text of plugins and suggested
 text didn't have the same styling and found when the `wp-suggested-text`
 div and italic css was added in
 [https://core.trac.wordpress.org/changeset/43184 Changeset#43184] it
 didn't apply to the plugin suggested text. To rectify this I've updated
 the css to use the other `policy-text` css wrapper as it applied both to
 the WP and plugin suggested text content.

 The only other difference now I'm seeing is the plugins often don't use
 the `<strong class="privacy-policy-tutorial">Suggested Text:</strong>`
 prefix on their content. That's more of an education thing though and can
 be handled in the documentation example found here;
 https://developer.wordpress.org/plugins/privacy/suggesting-text-for-the-
 site-privacy-policy/

 Can you review @azaozz and was wondering if this would warrant a dev-note
 or if that ship has sailed and maybe we get the plugins team to reach out
 to affected themes/plugins in order to prompt them to change from using
 `wp-policy-help` to `privacy-policy-tutorial` so they can support WP users
 from 5.1>5.4 who would be affected by the back-compat reversion?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49282#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform