[wp-trac] [WordPress Trac] #49274: Grunt copy:files should ignore node_modules

WordPress Trac noreply at wordpress.org
Fri Jan 24 00:25:55 UTC 2020


#49274: Grunt copy:files should ignore node_modules
------------------------------+------------------------------
 Reporter:  iandunn           |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by iandunn):

 [attachment:"49274.1.diff"] works for me, but could use some more
 eyes/testing.

 1. Clone several plugins that depend on many NPM packages into `src/wp-
 content/plugins` (e.g., gutenberg, yoast, coblocks, etc)
 1. Run `npm install` in each of their directories
 1. Go up to `src` and run `npm run dev`
 1. Change some files in `src`. If there are enough files inside
 `plugins/**/node_modules`, then you'll get this error from the `watch`
 task:

 {{{
 Running "_watch" task
 Waiting...
 Warning: Maximum call stack size exceeded
 }}}

 5. Cancel the `npm run dev` task
 5. Apply the patch
 5. Restart `npm run dev`, and change some files.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49274#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list