[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
WordPress Trac
noreply at wordpress.org
Wed Jan 22 23:26:13 UTC 2020
#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
-------------------------------------------------+-------------------------
Reporter: gziolo | Owner: gziolo
Type: enhancement | Status: reopened
Priority: normal | Milestone: 5.4
Component: Script Loader | Version: trunk
Severity: normal | Resolution:
Keywords: dev-feedback needs-patch 2nd- | Focuses: javascript
opinion |
-------------------------------------------------+-------------------------
Comment (by azaozz):
Replying to [comment:21 gziolo]:
> @azaozz - what kind of warnings do you see?
A big bunch of `PHP Warning: include(.../src/wp-
includes/assets/dist/[name].php): failed to open stream: No such file or
directory in ...\src\wp-includes\script-loader.php on line 295` (that's
before the phpunit tests start).
> I have a related question to that. Is there any clean way to leave
feedback to the developer when those files are missing which doesn't break
unit tests? It would be great for debugging purposes. @jorgefilipecosta
had some issues with the missing package which wasn't listed in the core
but was added in Gutenberg lately.
I may be misunderstanding but wouldn't that throw a js error or show a 404
in the browser console?
Generally thinking that splitting these files is not a great idea. I
understand that it makes it somewhat easier to build, but the "building
tools" are to make things better/easier, not to add more complexity :)
Integrating the DependencyExtractionWebpackPlugin shouldn't be changing
how the production code works, it should be making building easier and
keeping the code working in the most efficient/best way.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list