[wp-trac] [WordPress Trac] #44621: Privacy Policy Guide: Improve the readability of the suggested text

[WordPress Trac]

#44621: Privacy Policy Guide: Improve the readability of the suggested text
-------------------------------------+-------------------------------------
 Reporter:  birgire                  |       Owner:  garrett-eclipse
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.4
Component:  Privacy                  |     Version:  4.9.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch needs-testing needs-design-  |  css, administration
  feedback                           |
-------------------------------------+-------------------------------------
Changes (by xkon):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch needs-testing needs-design-feedback


Comment:

 Allow me to make a recap here as I've gone through everything and checked
 patches from the start and I'm also adding a `needs-design-feedback` for a
 quick look again as well from the design team :).

 The current text (as well as the incoming from any plugin) is just divided
 by `<p>` elements. As seen on [attachment:44621_context.jpg] the suggested
 text might have 3-4 paragraphs which means that visually they are divided
 if we start adding backgrounds, borders etc "as they are".

 The `<div>` wrapping proposal is definitely solving this, but

 1. we have to take under account & inform all plugin authors to change
 their output if they want a nice looking suggestion text.
 2. we will result on copying yet another <div> on the front-end of the
 websites as @sabernhardt mentions.

 --

 I personally feel like the best approach here ( and more likely the one
 that we can safely take ) would be using an earlier patch on this ticket
 with a result as seen at [attachment:44621-white-background.png].

 [attachment:44621-white-background.diff] cleverly removes the margin
 between the suggested text `<p>` elements so they look to be like 1
 unified body by not using any borders also.

 With this approach, there won't be any difference in the HTML output and
 plugins can continue to use their existing code.

 There's no change at all here from a Privacy point of view, so the final
 decision to be made is from an accessibility & design point of view.

 --

 I'll also be opening another ticket now as I feel it's somewhat relative,
 I was going to wait for after 5.4 but I guess the sooner the better the
 way this discussion here goes :).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44621#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform