[wp-trac] [WordPress Trac] #49250: i18n: replace %s placeholder type in wp-admin/includes/ms.php

[WordPress Trac]

#49250: i18n: replace %s placeholder type in wp-admin/includes/ms.php
-------------------------------------+-------------------------------------
 Reporter:  ramiy                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  I18N                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  administration,
  patch close                        |  multisite
-------------------------------------+-------------------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch close


Comment:

 Thanks for the patch!

 `%1$s` is used here so that we don't have to pass `$blog_name` to
 `sprintf()` twice to avoid a "Too few arguments" PHP warning. With the
 patch, `%s` is used twice in the string, so we'll also have to pass
 `$blog_name` twice.

 There are at least two other places in core with the same approach:
 * [source:tags/5.3.2/src/wp-
 admin/includes/misc.php?marks=128,130,134#L125]
 * [source:tags/5.3.2/src/wp-admin/includes/network.php?marks=247-249#L233]


 I don't see a significant benefit in breaking existing translations here
 just to change the placeholder.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49250#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform