[wp-trac] [WordPress Trac] #46894: Personal Data Export Report: Table of contents for easier navigation

[WordPress Trac]

#46894: Personal Data Export Report: Table of contents for easier navigation
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui
  design                                         |
-------------------------------------------------+-------------------------
Changes (by xkon):

 * keywords:  has-screenshots has-patch needs-refresh needs-design => has-
     screenshots has-patch needs-design


Comment:

 [attachment:"46894.2.diff"] refreshes the patch to be properly applied and
 adjusts the TOC as seen on [attachment:"46894.2_preview.png"] it also uses
 `sanitize_title_with_dashes()` and will show the TOC only if there are
 more than 1 groups on the page to fix the issues from comment [comment:5].

 @garrett-eclipse, I don't think that we need to provide a
 "group_toc_label" as mentioned in the same comment. Plugins / Themes
 should be already "branding" their groups by adding the plugin name also
 to avoid conflicts or data that can't be easily be attached to specific
 plugins. If they are not doing it then we have to communicate it better
 :).

 @karmatosed, do we really need to re-design this "at this point" :D? I'm
 asking as it's just a utility page & a simple means to an end for whoever
 wants to take a look at their data. If you really think that we should re-
 design this (and there's no time at the moment for that) would it be OK to
 at least get this ticket in for 5.4?

 We can then open up a fresh ticket for a full redesign for a future
 release (we need to see if accessibility is ok on this page also that's
 why I'm proposing a fresh re-design on a different ticket to address all
 possible issues in 1 go).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46894#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform