[wp-trac] [WordPress Trac] #48716: Improve wording for PHP update warning // Part 2

[WordPress Trac]

#48716: Improve wording for PHP update warning // Part 2
---------------------------------------+----------------------
 Reporter:  grafruessel                |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  5.4
Component:  Site Health                |     Version:  5.3
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui-copy
---------------------------------------+----------------------
Changes (by garrett-eclipse):

 * keywords:  needs-refresh => has-patch has-screenshots


Comment:

 Thanks for the feedback everyone, I've refreshed the patch in
 [https://core.trac.wordpress.org/attachment/ticket/48716/48716.4.diff
 48716.4.diff] to accommodate everyone's input.

 Current verbiage;
 - Your site is running the current version of PHP (%s)
 - Your site is running an older version of PHP (%s)
 - Your site is running an older version of PHP (%s) which should be
 updated
 - Your site is running an older version of PHP (%s) which requires an
 update

 The two changes are;
 1. Switching 'outdated' for 'older' due to @Clorith
 [https://core.trac.wordpress.org/ticket/48716#comment:9 comment]
 2. Switching 'and' for 'which' due to @SergeyBiryukov
 [https://core.trac.wordpress.org/ticket/48716#comment:11 comment], this
 should hopefully tie the 'should be updated' and 'requires an update' to
 PHP instead of the site to remove confusion.

 @marybaum  I didn't adopt your suggestions as this string is to be used as
 the accordion heading so brevity is key and I wanted to avoid having
 multiple lines in a heading. For context on placement see this screenshot;
 [[Image(https://core.trac.wordpress.org/raw-
 attachment/ticket/48716/Screen%20Shot%202019-11-19%20at%2010.32.54%20AM.png)]]

 I feel this is ready to commit but would appreciate your blessing @Clorith
 as you're the maintainer.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48716#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform