[wp-trac] [WordPress Trac] #49163: Some typing mistakes in \wp-admin\includes\class-pclzip.php

[WordPress Trac]

#49163: Some typing mistakes in \wp-admin\includes\class-pclzip.php
----------------------------+-----------------------------
 Reporter:  passoniate      |       Owner:  SergeyBiryukov
     Type:  defect (bug)    |      Status:  reviewing
 Priority:  normal          |   Milestone:  5.4
Component:  Filesystem API  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  docs
----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * component:  General => Filesystem API
 * milestone:  Awaiting Review => 5.4


Comment:

 Thanks for the patch!

 Per comment:3:ticket:38464, `class-pclzip.php` used to be treated as an
 external library and was excluded from any documentation fixes. We only
 modify third-party libraries when it's needed to fix a bug, like in
 [46105/trunk/src/wp-admin/includes/class-pclzip.php] or [38101/trunk/src
 /wp-admin/includes/class-pclzip.php].

 That said, looking at the [https://core.trac.wordpress.org/log/trunk/src
 /wp-admin/includes/class-pclzip.php?mode=follow_copy commit history],
 there were some whitespace changes in [12042/trunk/wp-admin/includes
 /class-pclzip.php] and documentation additions in [8645/trunk/wp-
 admin/includes/class-pclzip.php].

 Given that the [http://old.phpconcept.net/pclzip/index.en.php upstream
 library] hasn't been updated in 10 years since the last time it was
 merged, I think it's safe to treat it as "adopted" rather than external,
 same as [comment:11:ticket:48467 jquery.imgareaselect.js] or
 [comment:2:ticket:48267 class-IXR.php], and make these fixes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49163#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform