[wp-trac] [WordPress Trac] #49015: Twenty Twenty: Property font-size is overwritten - coding standard.

[WordPress Trac]

#49015: Twenty Twenty: Property font-size is overwritten - coding standard.
-----------------------------------+-----------------------
 Reporter:  ankitmaru              |       Owner:  desrosj
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  5.3.3
Component:  Bundled Theme          |     Version:  5.3
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch fixed-major  |     Focuses:  css, rtl
-----------------------------------+-----------------------

Comment (by SergeyBiryukov):

 For some context, it used to be a common practice to provide a `px`
 fallback for `rem` unit in older bundled themes, from Twenty Twelve to
 Twenty Seventeen.

 That's [https://caniuse.com/#feat=rem no longer necessary for modern
 browsers], so Twenty Nineteen and Twenty Twenty no longer do that, apart
 from the instance in `.screen-reader-text:focus` fixed above.

 Note that the current
 [https://make.wordpress.org/accessibility/handbook/markup/the-css-class-
 screen-reader-text/ recommended CSS for .screen-reader-text:focus] no
 longer includes `font-size: 14px`. However, it's still referenced in a
 recent [https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-
 skip-links/ How to add and test skip links] post on Theme Review Team's
 blog.

 [47053] looks good, but I think the same should be done for Twenty
 Nineteen for consistency, while we're at it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49015#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform