[wp-trac] [WordPress Trac] #49016: Coding Standards: Twenty Seventeen Theme - Use strict comparison in assets/js/html5.js

[WordPress Trac]

#49016: Coding Standards: Twenty Seventeen Theme - Use strict comparison in
assets/js/html5.js
---------------------------+-------------------------------------------
 Reporter:  ankitmaru      |       Owner:  (none)
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:  wontfix
 Keywords:  has-patch      |     Focuses:  javascript, coding-standards
---------------------------+-------------------------------------------
Changes (by desrosj):

 * status:  new => closed
 * version:  5.3 => 4.7
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Hi @ankitmaru,

 Thanks for this ticket!

 The `html5.js` file is an external JavaScript file packaged with the theme
 for maximum HTML5 compatibility in older browsers. This file is
 intentionally copied verbatim to make updating it easier (changes made in
 Core won't get overwritten when copying over a new version of the
 library).

 The version of the shiv included in the Twenty Seventeen is the most
 recent version (which has
 [https://github.com/aFarkas/html5shiv/commits/master not seen any commit
 activity since 2017]). The browsers and versions it aims to support (IE
 6-9, Safari 4.x, iPhone 3.x and Firefox 3.x) are used by very few, and
 that's likely the reason why it has not been updated in some time.
 WordPress also no longer supports IE < 11.

 For these reasons, I am going to close this out. Any changes that you feel
 should be made should be reported upstream to the
 [https://github.com/aFarkas/html5shiv shiv's GitHub] and can be copied
 over if an updated version of the shiv is released. But, that task would
 be the lowest priority IMO.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49016#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform