[wp-trac] [WordPress Trac] #48104: Add the gutenberg_provide_render_callback_with_block_object shim to core

WordPress Trac noreply at wordpress.org
Wed Jan 8 13:35:37 UTC 2020


#48104: Add the gutenberg_provide_render_callback_with_block_object shim to core
-------------------------------------------------+-------------------------
 Reporter:  andraganescu                         |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.4
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:
  note needs-docs                                |
-------------------------------------------------+-------------------------

Comment (by andraganescu):

 @aduth I tried and tried by can't remember all the details, other than the
 main issue being that innerBlocks were not passed into the render callback
 so we could not loop through them to make the navigation nested lists.

 I believe you're right at this point:

 > it's a scenario where, in retrospect, we should have just given the
 $block object as the sole parameter and left it to the block to deal with.

 Indeed, allowing blocks to set their own hooks to render_block filter
 might be a great idea, but more usecases could let us know of how this
 will be used.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48104#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list