[wp-trac] [WordPress Trac] #48871: i18n: WordPress update string

[WordPress Trac]

#48871: i18n: WordPress update string
-------------------------------------------------+-------------------------
 Reporter:  ramiy                                |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  I18N                                 |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch 2nd-       |     Focuses:
  opinion close                                  |  administration
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch 2nd-
     opinion close


Comment:

 Thanks for the ticket!

 As seen in [source:tags/5.3.2/src/wp-admin/includes/class-wp-automatic-
 updater.php?marks=868,871,885-887,893,899-901,908#L863 class-wp-automatic-
 updater.php], here's the list of the affected strings:

 * `SUCCESS: WordPress was successfully updated to %s`
 * `FAILED: WordPress failed to update to %s`
 * These strings are also displayed with the `SUCCESS:` prefix:
  * `The following plugins were successfully updated:`
  * `The following themes were successfully updated:`
  * `The following translations were successfully updated:`
 * These strings are also displayed with the `FAILED:` prefix:
  * `The following plugins failed to update:`
  * `The following themes failed to update:`
  * `The following translations failed to update:`

 While we don't generally include the `SUCCESS:` or `FAILED:` prefix in
 strings displayed in the UI, I think these strings from
 `WP_Automatic_Updater::send_debug_email()` are different in that they're
 used in debugging emails for easier scanning, to take a quick look (or
 maybe set up alert notifications) if there are any failures.

 I don't see any benefit in removing these prefixes. We could probably
 remove the prefix from the first two strings and re-add it with
 `sprintf()`, same as for [source:tags/5.3.2/src/wp-admin/includes/class-
 wp-automatic-updater.php?marks=868,871,885-887,893,899-901,908#L877 plugin
 and theme notifications], but I don't see what problem would that solve
 either.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48871#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform