[wp-trac] [WordPress Trac] #49122: Coding Standard : Javascript - /src/js/_enqueues/wp/customize/base.js

[WordPress Trac]

#49122: Coding Standard : Javascript - /src/js/_enqueues/wp/customize/base.js
-------------------------+-------------------------------------------
 Reporter:  ankitmaru    |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  5.4
Component:  Customize    |     Version:  5.3.2
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:  javascript, coding-standards
-------------------------+-------------------------------------------

Comment (by adamsilverstein):

 Noting that [r47038] also added an equality check change to a strict
 equality check, which looks good here - however in some circumstances this
 might break intended functionality, so its important to review these types
 of changes very carefully.

 @ankitmaru & @SergeyBiryukov  I appreciate your effort and contributions
 here, however I'm concerned that these changes are being made to refactor
 old coding to conform to coding standards for standards sake only. I'm all
 for coding standards, and improving our code quality, and in fact we have
 been working towards adding Prettier so our agreement can be enforced. I'm
 mainly concerned that the refactoring effort here might be wasted effort,
 or introduce unintended side effects. See
 https://make.wordpress.org/core/handbook/contribute/code-refactoring/.

 If there is a desire to refactor old code to bring it up to standards, I
 would like to coordinate the effort with our JS team, I would be happy to
 bring it up at our next weekly JS chat.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49122#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform