[wp-trac] [WordPress Trac] #44264: Give progress indication for export and erasure

[WordPress Trac]

#44264: Give progress indication for export and erasure
-------------------------------------------------+-------------------------
 Reporter:  allendav                             |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  ui,
  testing                                        |  javascript
-------------------------------------------------+-------------------------

Comment (by pbiron):

 Replying to [comment:32 garrett-eclipse]:
 > In [https://core.trac.wordpress.org/attachment/ticket/44264/44264.8.diff
 44264.8.diff] I took an alternate approach to avoid breaking that tab
 functionality. Instead of affecting the other classes to break the hover
 effect on the row actions I introduced a `.processing` class which matches
 the `.visible` class but won't be removed by other pre-existing
 functionality. This approach I found is less code heavy as well which is a
 bonus.

 yes, less code is better :-) And yours seems to work great.

 > Also note two other items in this patch;
 > 1. The erasure click handler was missing the `event.preventDefault();`
 so I added it to match with the export click handler.
 > 2. There was a hide call on the handlers upon success that made it so
 additional exports weren't possible. This was added unintentionally when
 we tried to make the two processes match in [46412] / #43974. As this
 affects this process and is a reversion in and of itself I included in
 this patch. If needed can be split out to a new ticket/patch but feel it's
 fairly safe to fix two reversions in one go here.

 Re: number 2: I'd encountered that problem while testing the commit
 (before working on my patch), but couldn't track down what was causing it.
 I think fixing both of those is great.

 I just noticed something else (I think that is unrelated to either your
 patch or mine)...give me a few more minutes to investigate it more.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44264#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform