[wp-trac] [WordPress Trac] #48198: Customizer: Can't get out of search view in Menu editor

[WordPress Trac]

#48198: Customizer: Can't get out of search view in Menu editor
-------------------------------------+-------------------------------------
 Reporter:  garrett-eclipse          |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:  5.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, javascript,
  patch needs-testing                |  administration
-------------------------------------+-------------------------------------
Changes (by afercia):

 * version:  4.6 => 5.1


Comment:

 After some additional software archeology, I think this broke in WordPress
 5.1 after [44539] where the `keyup` event was removed for both the Menus
 and Widgets searches.

 The `keyup` event was also programmatically triggered to clear the search
 and reset the search results thus also the Widgets search reset was
 broken.

 [45658] / #47534 fixed the issue for the Widgets but it didn't fix the
 Menus.

 [attachment:"48198.2.diff"] just changes the `keyup` remnants to `input`
 to restore the intended behavior. It's a simpler approach and doesn't
 require to repeat code that is already in place. Some testing would be
 nice :)

 Note: the patch also removes some stray spaces and tab characters because
 my editor does that automatically.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48198#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform