[wp-trac] [WordPress Trac] #46964: ID attribute value are used multiple times in "Custom Field" form
WordPress Trac
noreply at wordpress.org
Wed Feb 26 02:43:56 UTC 2020
#46964: ID attribute value are used multiple times in "Custom Field" form
-------------------------------------------------+-------------------------
Reporter: jankimoradiya | Owner: audrasjb
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.4
Component: Editor | Version: 5.0
Severity: normal | Resolution:
Keywords: has-screenshots has-patch early | Focuses: ui,
commit needs-dev-note | accessibility
-------------------------------------------------+-------------------------
Comment (by johnjamesjacoby):
Hey friends. I found 2 plugins of mine that have broken styling due to
this change.
[https://github.com/stuttter/wp-multi-network WP Multi Network]
[https://github.com/stuttter/wp-user-profiles WP User Profiles]
For context, these plugins both implement their own versions of the "Add
New" interface commonly associated with the Classic Editor experience. As
such, they've manually implemented the DOM hierarchy from it, starting
with `#poststuff` and finishing with `#postbox-container-1` and `#postbox-
container-2` both of which contain their own registered meta-boxes for
their own screens.
I don't mind changing the ID to a class in my screens. I understand there
are no guarantees that the admin-area DOM or accompanying styling will
never change, so by copying it I'm assuming the responsibility to maintain
my own copy.
Since it is highly unlikely that my own screens will suffer the problem
this ticket aims to solve, I may use both the ID and the class in my
plugins to be prepared either way.
Good luck with this one, everyone!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46964#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list