[wp-trac] [WordPress Trac] #48198: Customizer: Can't get out of search view in Menu editor
WordPress Trac
noreply at wordpress.org
Tue Feb 25 21:46:42 UTC 2020
#48198: Customizer: Can't get out of search view in Menu editor
-------------------------------------+-------------------------------------
Reporter: garrett-eclipse | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: 4.6
Severity: normal | Resolution:
Keywords: has-screenshots has- | Focuses: ui, javascript,
patch needs-testing | administration
-------------------------------------+-------------------------------------
Changes (by garrett-eclipse):
* keywords: has-screenshots => has-screenshots has-patch needs-testing
* version: => 4.6
Comment:
Thanks for pointing me in the right direction @afercia, I've uploaded an
initial patch to address this in
[https://core.trac.wordpress.org/attachment/ticket/48198/48198.diff
48198.diff].
Please test, I've uploaded a screencast of the resulting change. Now when
clicking the `clear-results` X button we reset the search panel and hide
the X button.
Note: I'm not overly familiar with Customizer js so am unsure if how I
setup the `$searchSection`\`$otherSections` variables is correct or if
they should be attached to `this` like is done with `this.$clearResults`
and `this.$search`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48198#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list