[wp-trac] [WordPress Trac] #46367: Introduce a cancel button to the create new menu screen when 1 or more menus exist

WordPress Trac noreply at wordpress.org
Tue Feb 25 20:04:54 UTC 2020


#46367: Introduce a cancel button to the create new menu screen when 1 or more
menus exist
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5
Component:  Menus                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots commit     |     Focuses:  ui,
  early                                          |  administration
-------------------------------------------------+-------------------------

Comment (by garrett-eclipse):

 Replying to [comment:5 SergeyBiryukov]:
 > [attachment:"46367.3.diff"] looks good, but it appears to display the
 Cancel link even when no menus are created yet, which just leads to the
 same screen. To make sure the logic is correct, let's move to early 5.5.

 Thanks @SergeyBiryukov good catch. I've corrected this in
 [https://core.trac.wordpress.org/attachment/ticket/46367/46367.5.diff
 46367.5.diff] to suppress the Cancel link when no menus are present.
 *Note: Please ignore 46367.4.diff there was some unintended changes to the
 `src/wp-includes/assets/script-loader-packages.php` file.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46367#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list