[wp-trac] [WordPress Trac] #48772: Missing post ID as parameter for get_comments_number_text()

WordPress Trac noreply at wordpress.org
Tue Feb 25 17:32:48 UTC 2020


#48772: Missing post ID as parameter for get_comments_number_text()
------------------------------+-----------------------
 Reporter:  Hinjiriyo         |       Owner:  donmhico
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  5.4
Component:  Comments          |     Version:  4.0
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"47366" 47366]:
 {{{
 #!CommitTicketReference repository="" revision="47366"
 Comments: Restore the fourth parameter of `comments_number()` as
 `$post_id`, for consistency with `get_comments_number_text()`.

 The parameter was previously used as the number of comments, marked as
 deprecated in [5101].

 Given that it's been deprecated for the last 13 years, it should be safe
 to undeprecate and repurpose it for a cleaner function signature, instead
 of adding a fifth parameter.

 Follow-up to [47276].

 Fixes #48772.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48772#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list