[wp-trac] [WordPress Trac] #49387: Run pre_render_block filter in block-renderer REST controller

WordPress Trac noreply at wordpress.org
Tue Feb 25 13:49:55 UTC 2020


#49387: Run pre_render_block filter in block-renderer REST controller
--------------------------------------+-------------------------
 Reporter:  kadamwhite                |       Owner:  kadamwhite
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  5.4
Component:  Editor                    |     Version:  5.1
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  rest-api
--------------------------------------+-------------------------

Comment (by miinasikk):

 @kadamwhite The discussed filters didn't exist at the time of adding this
 endpoint, and the `render_block` method was quite small containing just a
 few reusable lines and would have required a few more extra lines for
 reusing it, it probably made more sense to just not use it.

 That might not be the case anymore though, as far as I remember, no other
 particular reason for not using the `render_block`.

 Replying to [comment:7 kadamwhite]:
 > @TimothyBlynJacobs I assumed that the render_block method was
 deliberately not being used here for some reason. @miinasikk, @matveb
 @westonruter and others were involved in
 [https://github.com/WordPress/gutenberg/pull/5602 the initial Gutenberg PR
 (#5602)] and may be able to provide that context.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49387#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list