[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build

[WordPress Trac]

#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
------------------------------+-------------------------
 Reporter:  gziolo            |       Owner:  gziolo
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  5.4
Component:  Script Loader     |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  javascript
------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:54 gziolo]:

 > > TODO/TBD: Wondering if the assets file should be committed
 >
 > Yes, I think we should do it now that we have only one file that can
 change.

 OK, will do.

 > `$packages = array_keys( $assets );`
 >
 > I like this part the most that allows removing the list of packages
 which was maintained manually so far.

 Yep, much better than having to do it manually (it doesn't even need
 `array_keys()`, can do the same inside the loop).

 > I think we can also remove the list of packages that have translations
 and perform a simple check whether `wp-18n` is listed as a dependency
 instead.

 Yes, would be better. Looked there a bit, three more packages have `wp-
 18n` as dependency: `annotations`, `media-utils`, and `server-side-
 render`.

 > It would be great to commit this patch to have it included in Beta 3 so
 feel free to land as-is and we can handle the rest later.

 Of course. Will update the patch shortly, then go through it once more
 tomorrow and commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform