[wp-trac] [WordPress Trac] #48091: Remove conditional use of PHP stream_get_contents()

[WordPress Trac]

#48091: Remove conditional use of PHP stream_get_contents()
-----------------------------+--------------------------------------------
 Reporter:  jrf              |       Owner:  SergeyBiryukov
     Type:  task (blessed)   |      Status:  reviewing
 Priority:  normal           |   Milestone:  5.5
Component:  General          |     Version:  5.3
 Severity:  normal           |  Resolution:
 Keywords:  has-patch early  |     Focuses:  performance, coding-standards
-----------------------------+--------------------------------------------
Changes (by jrf):

 * keywords:  has-patch => has-patch early
 * milestone:  Future Release => 5.5


Comment:

 I understand moving it out of the current release as it's in beta stage
 already. I do think this should be addressed sooner rather than later, so
 let's make it 5.5 `early`.

 > However, just in case, would it make sense to add an upgrade check for
 stream_get_contents(), like [46455]?

 I honestly think that would be overkill. `JSON` is an extension and PHP
 can be compiled without it. `stream_get_contents()` is part of PHP core.

 Either way, if this gets committed `early` in WP 5.5, it would allow for
 issues to be reported well before the release and if someone _does_ report
 an issue, we can always revisit and add the check in the `upgrade` routine
 before the actual release.

 @SergeyBiryukov How does that sound to you ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48091#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform