[wp-trac] [WordPress Trac] #49476: Incorrect links to export/delete personal data in emails
WordPress Trac
noreply at wordpress.org
Wed Feb 19 22:11:54 UTC 2020
#49476: Incorrect links to export/delete personal data in emails
-------------------------------------+---------------------
Reporter: Jurgen Oldenburg | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3.3
Component: Privacy | Version: 5.3
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+---------------------
Changes (by garrett-eclipse):
* keywords: needs-patch => has-patch needs-testing
* version: => 5.3
* milestone: Awaiting Review => 5.3.3
Comment:
Thanks @jurgen-oldenburg for catching this.
I've updated the links in
[https://core.trac.wordpress.org/attachment/ticket/49476/49476.diff
49476.diff] to point to the new locations.
Also while looking into this I found there was some redirect code in the
tools.php which was supposed to mitigate the change by redirecting to the
proper new location;
This unfortunately is run after the `/wp-admin/admin.php` require which
through a later require of `wp-admin/includes/menu.php` does a
`user_can_access_admin_page` check and fails due to the pages no longer
existing. To address this I moved the conditional before the require and
added `wp-load.php` require_once calls in order to have `wp_redirect`
function.
@SergeyBiryukov I've milestoned for 5.3.3 as this is a reversion
introduced on that branch but am wondering if it's not too late for 5.4.
CC @azaozz as the original committer of the privacy re-organization.
Mostly wanting to see if my approach to the back-compat redirect is
appropriate.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49476#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list