[wp-trac] [WordPress Trac] #46718: Loading from source in WP_Widget_Media_Video

[WordPress Trac]

#46718: Loading from source in WP_Widget_Media_Video
--------------------------+-----------------------
 Reporter:  spacedmonkey  |       Owner:  desrosj
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  5.4
Component:  Widgets       |     Version:  4.8
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------
Changes (by desrosj):

 * keywords:  has-patch commit => has-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I'm reopening this to revert.

 After committing some tests started failing so I dug a bit deeper.

 Even though the `$attachment` check appears redundant, the intention of
 including it is to ensure the attachment's `src` is passed through
 `wp_video_shortcode()` and the associated filters. The `else` condition
 should only be used for videos that are not attachments, and those that do
 not match the special scenarios (YouTube/Vimeo).

 I am going to close this out after reverting, but if this assessment seems
 incorrect, please let me know!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46718#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform