[wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon

[WordPress Trac]

#48222: "Show password" button overlaps with the LastPass icon
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.4
Component:  Login and Registration               |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots dev-feedback has-    |     Focuses:  ui
  patch needs-testing                            |
-------------------------------------------------+-------------------------

Comment (by Clorith):

 I'm not a fan of the markup here, to reach the button to toggle visibility
 one would then have to navigate backwards, and would also be exposed to a
 potentially contextless "Show" before even being presented with the input.

 The toggle button needs its old label of `Show password`, we don't know
 what direction the user reaches the button, so retaining the context
 within the label is important.

 The button should also be moved to come after the input form, you can
 still use CSS for positioning, but markup needs to follow a natural
 pattern.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48222#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform