[wp-trac] [WordPress Trac] #49449: Wrong require_once and misleading comment

WordPress Trac noreply at wordpress.org
Mon Feb 17 03:22:56 UTC 2020


#49449: Wrong require_once and misleading comment
--------------------------+-----------------------------
 Reporter:  luisrivera    |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  5.4
Component:  REST API      |     Version:  5.3
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:  rest-api
--------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"47296" 47296]:
 {{{
 #!CommitTicketReference repository="" revision="47296"
 REST API: Restore `wp-admin/includes/image.php` requirement in
 `WP_REST_Attachments_Controller::create_item()`.

 Although the file is already included via the `::insert_attachment()`
 method, this addresses an inconsistency and corrects a misleading comment.

 It also reduces the possibility of a future error in case
 `::insert_attachment()` is no longer called earlier in `::create_item()`
 at some point.

 Follow-up to [43850] and [44206].

 Props luisrivera.
 Fixes #49449.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49449#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list