[wp-trac] [WordPress Trac] #42852: Add new user: new password not generated when reopening Show Password

[WordPress Trac]

#42852: Add new user: new password not generated when reopening Show Password
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.4
Component:  Users                                |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  javascript
  design                                         |
-------------------------------------------------+-------------------------

Comment (by bookdude13):

 My last refresh was more focused on code porting than functionality...so
 here's another attempt :)
 - This should match the four bullets mentioned by @afercia
 - For creating new users, changed it so the fields are never hidden. This
 also allows for a value to always be set and visible for the password when
 creating users. Since it's always visible I have the text set to "Generate
 New Password"
 - It still needs to be tested that passwords can't be set even if they
 were never visible, e.g. an edit profile/user page updating the password
 by accident when something else updates
 - I have not tested on other browsers or mobile, just Chrome.

 This still needs design review for the question of how to handle the
 Cancel button and where to put the Set New Password button (above or
 below)

 Replying to [comment:13 bookdude13]:
 > Patch refreshed. A few suggestions to improve (needs design review):
 > - When editing a user (or your own profile) the "Set New Password"
 button text could change to "Generate New Password" once the field
 appears.
 > - When editing a user (or your own profile) the "Cancel" button could
 hide all of the fields, making the "Set New Password" button act as a
 toggle for their appearance
 > - There is not a way to generate new strong passwords during
 installation
 > - It should be checked that #42853 didn't get reverted in this. The code
 that was changed from there were removed from the original patch here.
 > - Related: #42766

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42852#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform