[wp-trac] [WordPress Trac] #32940: Add IDs to Admin Hyperlinks

WordPress Trac noreply at wordpress.org
Sat Feb 15 22:37:54 UTC 2020


#32940: Add IDs to Admin Hyperlinks
-------------------------------------------------+-------------------------
 Reporter:  charlestonsw                         |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Administration                       |     Version:  4.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing dev-         |     Focuses:
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------
Changes (by valentinbora):

 * keywords:  good-first-bug has-patch => has-patch needs-testing dev-
     feedback 2nd-opinion
 * milestone:   => Future Release


Comment:

 [attachment:"32940.diff"] applies cleanly and seems to do the job, however
 I am concerned that it uses the menu label as a source for generating the
 `id` attribute, which depends on the used locale.

 I've switched WordPress to my native language (not English) and the menu
 ids also changed. For the purpose requested by the reporter (to be able to
 address specific menu items by CSS and/or JS), this is not stable enough
 in my opinion.

 Core folks, please chime in with thoughts and suggestions on how to
 otherwise address this better.

 Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/32940#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list