[wp-trac] [WordPress Trac] #40044: A little strange logic in get_header_video_url() function

WordPress Trac noreply at wordpress.org
Tue Feb 11 16:34:23 UTC 2020


#40044: A little strange logic in get_header_video_url() function
-------------------------+-----------------------------
 Reporter:  Tkama        |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  Future Release
Component:  Customize    |     Version:  4.7
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:
-------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"47267" 47267]:
 {{{
 #!CommitTicketReference repository="" revision="47267"
 Customize: Avoid unnecessary `get_theme_mod()` call and premature escaping
 in `get_header_video_url()`.

 The result is still escaped with `esc_url_raw()` for retrieval, and with
 `esc_url()` for display in `the_header_video_url()`.

 Props dlh, Tkama.
 Fixes #40044.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40044#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list