[wp-trac] [WordPress Trac] #48378: Firefox and Internet Explorer 11: Media modal controls section cut off at larger window sizes

[WordPress Trac]

#48378: Firefox and Internet Explorer 11: Media modal controls section cut off at
larger window sizes
----------------------------------------------+-----------------------
 Reporter:  sabernhardt                       |       Owner:  afercia
     Type:  defect (bug)                      |      Status:  assigned
 Priority:  normal                            |   Milestone:  5.4
Component:  Media                             |     Version:  5.3
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:  ui
----------------------------------------------+-----------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch has-screenshots commit


Comment:

 [attachment:"48378.2.diff"] builds on the previous patch and:
 - checks the input exists before using a DOM method like on it
 (`scrollIntoView()`)
 - uses a CSS `after` pseudo element instead of `padding-bottom` to reserve
 some space at the bottom of the affected elements

 For the CSS part: in this specific case I opted to repeat the same ruleset
 for each selector, to make very clear why it is used and also added inline
 comments accordingly.

 Looks good for commit to me. Will wait till Beta 1 tomorrow to give some
 time for anyone willing to test.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48378#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform