[wp-trac] [WordPress Trac] #48455: Missing Yoda condition

[WordPress Trac]

#48455: Missing Yoda condition
-------------------------------------+-------------------------------
 Reporter:  1naveengiri              |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.4
Component:  Administration           |     Version:  5.3
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:  coding-standards
-------------------------------------+-------------------------------

Comment (by SergeyBiryukov):

 In [changeset:"47220" 47220]:
 {{{
 #!CommitTicketReference repository="" revision="47220"
 Coding Standards: Correct the `get_plugin_page_hook()` check in `wp-
 admin/admin.php`.

 The condition is meant to check for a non-empty string, however
 `get_plugin_page_hook()` can return null, in which case the strict check
 doesn't work as expected.

 Follow-up to [47218].

 See #48455, #49222.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48455#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform