[wp-trac] [WordPress Trac] #41750: Update PHPMailer to 6.0
WordPress Trac
noreply at wordpress.org
Sat Feb 8 20:09:37 UTC 2020
#41750: Update PHPMailer to 6.0
-------------------------------------------------+-------------------------
Reporter: Synchro | Owner:
| SergeyBiryukov
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.4
Component: External Libraries | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing needs-dev- | Focuses:
note early |
-------------------------------------------------+-------------------------
Comment (by ayeshrajans):
Hi @Synchro, yes the test failures were from the undeclared
`PHPMailer\PHPMailer\Exception` class. [https://travis-ci.org/Ayesh
/wordpress-develop/jobs/647421945#L2743 CI log].
Even before this patch, WordPress [https://github.com/WordPress/wordpress-
develop/blob/e72fff9ceffb41d22c48febfc5f97c0cd46f5884/src/wp-
includes/pluggable.php#L216 Opts-in to exceptions] (with `new PHPMailer(
true )`).
So this patch preserves this behavior, and catches the new
`PHPMailer\PHPMailer\Exception`. I think this is safer because because we
get the strict validation from PHPMailer, and any unhandled exceptions
from WordPress side will rightfully bubble up.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41750#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list