[wp-trac] [WordPress Trac] #48455: Missing Yoda condition
WordPress Trac
noreply at wordpress.org
Fri Feb 7 23:29:17 UTC 2020
#48455: Missing Yoda condition
-------------------------------------+-------------------------------
Reporter: 1naveengiri | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.4
Component: Administration | Version: 5.3
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: coding-standards
-------------------------------------+-------------------------------
Comment (by bookdude13):
@alishankhan sorry if I'm hijacking this ticket, I wanted to help out a
bit with 5.4 and this was a good candidate :)
Refreshed patch, caught a couple more cases where this was happening. Just
needs some testing and another set of eyes to verify that the switched
variables aren't changing the logic.
Note that the patch was made with `git diff --no-ext-diff master >
48455.2.patch`. If a different command is needed for SVN compatibility let
me know and I can refresh.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48455#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list