[wp-trac] [WordPress Trac] #49358: Update WordPress packages
WordPress Trac
noreply at wordpress.org
Fri Feb 7 06:53:21 UTC 2020
#49358: Update WordPress packages
------------------------------+-------------------------------
Reporter: jorgefilipecosta | Owner: jorgefilipecosta
Type: defect (bug) | Status: closed
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses:
------------------------------+-------------------------------
Comment (by gziolo):
You included `@wordpress/scripts: 6.2.0 -> 7.0.0` in the description of
the commit but it wasn't included. Noting to ensure that everything went
well.
There is still one thing that needs to be improved on Gutenberg side:
`gutenberg_remove_empty_navigation_links_recursive` - this name of the
function in Navigation block is problematic, as it will fatal in the
plugin after release. It should have `gutenberg_` prefix removed. In
general, all the names of functions used should be prefixed with something
common, maybe `block_core_navigation_`?
To avoid function redeclaration in the Gutenberg plugin, there is Webpack
task that prepends all PHP functions with `gutenberg_`:
https://github.com/WordPress/gutenberg/blob/c605373f3e845da983193d2fa649d9a3cf777de8/webpack.config.js#L145-L179
Looking at it a bit more, it might work I have to double-check if the
function would be renamed to:
`gutenberg_gutenberg_remove_empty_navigation_links_recursive`
Still, the issue remains valid in general. @aduth do you have some
recommendations?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49358#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list