[wp-trac] [WordPress Trac] #49199: Introduce Automatic Update opt-in setting for Themes

[WordPress Trac]

#49199: Introduce Automatic Update opt-in setting for Themes
-------------------------------------+-------------------------------------
 Reporter:  audrasjb                 |       Owner:  audrasjb
     Type:  feature request          |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.4
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  dev-feedback has-        |     Focuses:  administration,
  screenshots has-patch needs-dev-   |  multisite
  note                               |
-------------------------------------+-------------------------------------

Comment (by peterwilsoncc):

 Added some general thoughts to the plugins ticket, sharing those that
 apply here too.

 * If `WP_DISABLE_THEMES_AUTO_UPDATE === true`,
 `wp_is_themes_auto_update_enabled()` should return early and never hit the
 filter. This will prevent developers overriding the site owner's hard
 coded choice.
 * For themes that use semantic versioning and therefore may have breaking
 changes between versions, do we need to modify the .org API to return
 `offer_minor` and `offer_patch` to allow the theme additional control over
 how it may be auto updated
 * To prevent `malicious-plugin` from messing what's offerer to `good-
 honest-themes`, do we need to use PHP Reflections to limit filters running
 on the the plugin to the theme itself. This is super complex I know but
 keep in mind the offered file can be changed from wp.org to malicious.org
 via filters. This is perhaps a topic for another time.
 * if `WP_DISABLE_THEMES_AUTO_UPDATE === true` and for sites using version
 control then the auto-updates UI ought not be displayed.
 * It looks like `WP_DISABLE_THEMES_AUTO_UPDATE` is a new constant, in
 which case please figure out a positive/negative setup so it matches the
 proposed `WP_AUTO_UPDATE_PLUGINS` in the plugins ticket.

 As with plugins, I think this is too late for 5.4. Could it be released as
 a feature plugin prior to the release of 5.5? Again, given everyone's hard
 work I apologise for the lateness of my feedback.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49199#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform