[wp-trac] [WordPress Trac] #18097: Themes update-check should check parent/child

[WordPress Trac]

#18097: Themes update-check should check parent/child
-----------------------------+-----------------------------
 Reporter:  nacin            |       Owner:  (none)
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  Future Release
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+-----------------------------

Comment (by garrett-eclipse):

 Replying to [comment:11 Otto42]:
 > No, the names all live in the same namespace, so they're unique. Can't
 have two themes with the same name in the directory.
 Thanks @Otto42 that's great news. So this safety check would only really
 benefit custom themes who've named their child theme the same as a parent
 theme on WP.org, or have their parent theme named the same as a child
 theme on WP.org.

 Seems like a fairly negligible benefit in that case and one which is being
 mitigated by education on custom themes should use a unique name not
 present in WP.org theme directory.

 Random thought, if `Theme URI` was (may already be) required for all
 WP.org themes and was required to match the WP.org theme page it could
 more realistically help in this manner. So custom themes that have no
 Theme URI or a non-WP.org Theme URI would be skipped over for updates
 avoiding custom themes being replaced. The only edge case there is a user
 accidentally using a Theme URI pointed to WP.org. And only if the Theme
 name and Theme URI match what's expected for the WP.org hosted theme would
 it prompt an update.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/18097#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform