[wp-trac] [WordPress Trac] #49348: Block Editor: Include navigation block php file

WordPress Trac noreply at wordpress.org
Wed Feb 5 11:31:50 UTC 2020


#49348: Block Editor: Include navigation block php file
------------------------------+-------------------------------
 Reporter:  jorgefilipecosta  |       Owner:  jorgefilipecosta
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.4
Component:  Editor            |     Version:  trunk
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-------------------------------

Comment (by andraganescu):

 Regarding the two functions mentioned by @TimothyBlynJacobs
 `build_css_colors` and `build_css_font_sizes` these are needed to extract
 color and font size CSS class / data because the block is using the new
 colors and fonts hooks.

 While working on adding features to the `PostAuthor` block I have also
 needed the same functions and, for reasons of moving the PR ahead, just
 copied them, see the GitHub issue [#19894
 https://github.com/WordPress/gutenberg/pull/19894]

 What would the solution be to have these as reusable code? Should we?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49348#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list