[wp-trac] [WordPress Trac] #44501: Change "From" email address for GDPR request confirmation email

[WordPress Trac]

#44501: Change "From" email address for GDPR request confirmation email
-------------------------------------------------+-------------------------
 Reporter:  zaffarn                              |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:
  tests needs-docs commit                        |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-testing needs-dev-note has-unit-tests needs-
     docs => has-patch needs-dev-note has-unit-tests needs-docs commit


Comment:

 Thanks @xkon this worked really nicely, some very minor tweaks in
 [https://core.trac.wordpress.org/attachment/ticket/44501/44501.4.diff
 44501.4.diff]

 1. In the `user_request_confirmed_email_headers` docblock corrected the
 mention of `$email_text` as it's `$content` that's used. And updated the
 $email_data block to match the expected for that email.
 2. Updated the description for `user_erasure_complete_email_headers`, and
 the `$email_data` contents to match the email.
 3. Updated `user_request_action_email_headers` to swap `$email_text` for
 `$content`.

 Unit tests worked nicely and all my tests cleared (I appreciate the
 [https://core.trac.wordpress.org/ticket/44501#comment:6 testing code] made
 things simple)

 Marking for final review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44501#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform