[wp-trac] [WordPress Trac] #49329: memory_limit in site health is not really correct, value is taken from wp_raise_memory_limit

WordPress Trac noreply at wordpress.org
Sat Feb 1 01:00:17 UTC 2020


#49329: memory_limit in site health is not really correct, value is taken from
wp_raise_memory_limit
--------------------------+-----------------------------
 Reporter:  espiat        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.4
Component:  Site Health   |     Version:  5.3.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  administration
--------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  dev-feedback => has-patch


Comment:

 Hi there, welcome to WordPress Trac! Thanks for the report, it's a good
 catch.

 Just noting that as of [47063], `WP_Site_Health` is instantiated in `wp-
 settings.php`, earlier than `wp_raise_memory_limit( 'admin' )` runs, so we
 can store the value in a class property instead of a global.

 [attachment:49329.diff] seems to work as expected in my testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49329#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list