[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.7
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:
  testing early                                  |
-------------------------------------------------+-------------------------

Comment (by afragen):

 ATM this is not quite meant to be all encompassing. Some of the issue is
 getting a WP_Error out of `copy_dir()`.

 It is meant to function if the `$dirlist` returns `false` as this is
 clearly an issue likely relating to the download, extraction , copy
 process. There's another ticket #51928 to help provide more data for where
 and when failures happen.

 The zipping is done before the any unpacking of the downloaded package and
 I'm not sure that it should increase the server resources significantly.
 If this can be demonstrated that would be great. But since the failure
 seems to be in `copy_dir()`, zipping the current plugin seems like a
 better solution than ''copying'' the data somewhere and then ''copying''
 it back.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform